First off since you can only take 3 pokemon into the battle tower you really should spread the types out anyway here's what I think for each of them
Starmie:
Good, standard set. Although I usually personally go with Thunderbolt, you should use Ice Beam for the battle tower (seen plenty of Nuzleafs there)
Lanturn:
Thunderbolt > Thunder in my personal opinion but if you think it's OK...
or you could always try to squeeze Rain Dance on there
Medicham:
you might want to go with Brick Break (not sure how strong HJK is), endless supply of the TM in FR/LG
that's it really, haven't dealt with him much
Masquerain:
I say if it's been working for you, go with it
Whiscash:
Looks good
Lunatone:
Looks good
Well I'm pretty new to this anyway, not too experieced with some of the newer ones but I hope that helps a little