A little explanation of each Pokémon's strategy would be very helpful. I'll help what I can, but I'm still a newbie at this.
Ninjask: With your moveset, try either Adamant or Jolly. Adamant would increase it's Attack and lower it's Special Attack while Jolly would increase it's Speed and lower it's Special Attack. I honestly have no idea for the item
Altaria: Same as my Altaria. Use an Adamant personality. For item, you should probably use Shell Bell or Leftovers.
Dusclops: Shadow Ball for Shadow Punch. More powerful and about as accurate. Impish personality. Once again, just like mine, so I know what works well.
Machamp: Adamant personality. You're not going to find any special attacks on this guy, so no need for that stat. And unless there is some other strange purpose for it to solve, Attack would be the only thing beneficial to increase. I'm not sure if Machamp could last a Rest unless you attach a Chesto Berry. Try Earthquake and Rock Slide for the last two moves. And I think you're only going to need either Cross Chop or Revenge, not both. IMO, choose Cross Chop. Unless you are against another sweeper, you're not likely to get the bonus for being hit every time. And if you don't get hit, Revenge only has a base power of 90 with STAB. Cross Chop, although a little inaccurate, already has a base power of 150 with STAB. And I remember liking Cross Chop from GSC.
Starmie: Sorry, I'm not specializing with FRLG yet, but I'll help with personality at stuff. Probably either Modest or Timid because both lower Attack and raise Special Attack or Speed, respectively. For item.. don't know, lol. Since I don't know the function of Starmie, I can't really help with any others. Maybe a Defense increasing personality? If so, go with Bold.
Manectric: Either Modest or Timid. I doubt this thing would do well withstanding anything even with increased defenses. Don't use Charge, it just wastes a turn. Two Thunderbolts, although using up an extra PP, would probably do the same damage and give you one extra turn to paralyze them with your attack. Might want to breed on Crunch. For your fourth move, do what you choose. Roar maybe?
I hope this was of some help.