Infernape Male Lv 48
Item: None
Skills: Fire Wheel
Fire Spin
Close Combat
Rock Smash
For Infernape, like Phoenix said, get rid of Rock Smash and Fire Spin ASAP. Swords Dance is a smart investment because its Speed is high enough for it to do move fast enough to do alot of damage. And keep Close Combat, because Infernape is not meant to stay alot for very long. Just comes in, does a shitload of damage and goes out whenever. I guess for the last move, throw on Stone Edge, since you can catch Flyers with that pretty easy. You could also make him into a good Special Sweeper using Nasty Plot:
Flamethrower
Nasty Plot
Grass Knot
Focus Blast/Close Combat
Focus Blast is Special-based (at least I believe it is) but its accuracy leaves a lot to be desired. Close Combat is a little more reliable, but doesn't work off of Nasty Plot. Again, its up to you what type of Sweeper you want
Golduck Female Lv 50
Item: Quick Claw
Skills: Water Pulse
Ice Beam
Confusion
Zen Headbutt
Yeah, Confusion definitely needs to be replaced with Psychic, as well as Water Pulse with Surf. I say just take Zen Headbutt out for Calm Mind and you got your Special Sweeper there.
Luxray Male Lv 45
Item: Dread Plate
Skills: Thunder Fang
Spark
Bite
Crunch
Luxray, one of my new favorites from D/P. Definitely get Ice Fang in there for him, so he can take out those Grass and Ground types he always has problems with. Replace Bite with Thunder Wave for sure since you already have Crunch in there. I say for the last move use either Thunder Fang or Thunderbolt. Thunder Fang because he has a higher Atk but Thunderbolt also has a higher BP so I'm not sure, which ever you prefer.
Leafeon Male Lv 50
Item: Shell Bell
Skills: Synthesis
Magical Leaf
Giga Drain
Quick Attack
Whoa now, you DEFINITELY need to revamp your whole Leafeon set. As Phoenix mentioned, Leafeon is meant to be a Physical attacker, strickt and foremost. I guess go with Razor Leaf for now, until he learns Leaf Blade, cause that's his strongest attack.
Flygon Female Lv 50
Item: None
Skills: Dragon Breath
Dragon Claw
Fly
Crunch
Eh...I'm not liking the set too much for Flygon. Keep Dragon Claw and try this:
Dragon Claw
Rock Slide
Earthquake
Flamethrower/Fire Blast/Crunch
Unfortunately, Flygon doesn't learn any Physical-based Fire attacks, so I would personally go with Fire Blast since it has more BP and can do more damage for the Ice-types. But then again, you also have Rock Slide to handle Ice-types, so you could add on Crunch for versatility. Again, up to you.